Add support for the 32 Bit Arm architectures. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinkelhacker
force-pushed
the
master
branch
from
2a78f90 to
3bb3690
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I've been using this crate for some time so first of all thanks for putting it together.
Recently, I have been doing more stuff with different Cortex-M cpus so I added support for 32 bit arm architectures. I have only tested it for a cortex-m7 (armv7em). I'm still confused about ARM's architecture naming but as far as I understand it "Aarch32" should be the generic name for all 32 bit architectures across all profiles?!
If this is something you'd like to merge let me know. I can also do some changes to the PR if needed.